Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests to latex definitions files #1161

Merged
merged 1 commit into from
Dec 17, 2024
Merged

add tests to latex definitions files #1161

merged 1 commit into from
Dec 17, 2024

Conversation

kaligrafy
Copy link
Collaborator

verify consistence between all languages and verify possible duplicates

@kaligrafy kaligrafy mentioned this pull request Dec 17, 2024
Merged
@kaligrafy
Copy link
Collaborator Author

needs rebasing on #1158

greenscientist
greenscientist requested changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@greenscientist greenscientist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the reference language is configurable, the variable and test name should reflect that

packages/transition-backend/file/__tests__/definitions.test.ts Outdated Show resolved Hide resolved
packages/transition-backend/file/__tests__/definitions.test.ts Outdated Show resolved Hide resolved
@kaligrafy kaligrafy force-pushed the addLatexDefinitionsTests branch 3 times, most recently from 067448e to f263361 Compare December 17, 2024 15:51
GabrielBruno24
GabrielBruno24 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@GabrielBruno24 GabrielBruno24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yannick's comments should be adressed, but I approve after that.

@kaligrafy kaligrafy force-pushed the addLatexDefinitionsTests branch from f263361 to 88e5d37 Compare December 17, 2024 15:58
@kaligrafy
add tests to latex definitions files
7095c98 
verify consistence between all languages and verify possible duplicates
@kaligrafy kaligrafy force-pushed the addLatexDefinitionsTests branch from 88e5d37 to 7095c98 Compare December 17, 2024 18:13
@kaligrafy kaligrafy merged commit d4cfba6 into chairemobilite:main Dec 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabrielBruno24 GabrielBruno24 GabrielBruno24 approved these changes

@greenscientist greenscientist greenscientist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaligrafy @greenscientist @GabrielBruno24